Skip to content

Trac #65313: Extend WP_Comment_Query 'fields' to support individual c…#11935

Closed
Anupkankale wants to merge 3 commits into
WordPress:trunkfrom
Anupkankale:trac-65313-comment-query-fields-columns
Closed

Trac #65313: Extend WP_Comment_Query 'fields' to support individual c…#11935
Anupkankale wants to merge 3 commits into
WordPress:trunkfrom
Anupkankale:trac-65313-comment-query-fields-columns

Conversation

@Anupkankale
Copy link
Copy Markdown

…olumn names

  • Accepts a single valid column name (e.g. 'comment_post_ID') and returns a flat array of scalar values
  • Accepts an array of valid column names and returns stdClass objects per row
  • Invalid column names fall back to full WP_Comment objects
  • Existing 'ids' and '' (default) behaviour unchanged
  • Follows the same pattern as WP_User_Query

Fixes https://core.trac.wordpress.org/ticket/65313

Trac ticket:

Use of AI Tools


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

…olumn names

- Accepts a single valid column name (e.g. 'comment_post_ID') and returns a flat array of scalar values
- Accepts an array of valid column names and returns stdClass objects per row
- Invalid column names fall back to full WP_Comment objects
- Existing 'ids' and '' (default) behaviour unchanged
- Follows the same pattern as WP_User_Query

Fixes https://core.trac.wordpress.org/ticket/65313
@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props anupkankale.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@westonruter
Copy link
Copy Markdown
Member

Thanks for the PR, but I'm closing in favor of #11934 since it lacks coding standards issues while also including unit tests. If you have any suggestions for that PR, please add them there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants