[Personal WP] Install my-apps on existing personal sites#3768
Open
akirk wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a shared “my-apps” (App Launcher) blueprint helper and introduces a one-off migration flow to ensure older Personal WP sites have the plugin installed, persisting and cross-tab syncing a migration marker.
Changes:
- Add
appliedMigrationsto site metadata and include it in cross-tab metadata sync. - Introduce
personalwp/my-appshelpers for blueprint URL creation and plugin presence checks (with tests). - Add an automatic migration in the viewport to install my-apps when missing and record the migration timestamp.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/playground/personal-wp/src/lib/state/redux/slice-sites.ts | Adds appliedMigrations field to persisted site metadata. |
| packages/playground/personal-wp/src/lib/state/redux/cross-tab-sync.ts | Syncs appliedMigrations across tabs. |
| packages/playground/personal-wp/src/lib/state/redux/cross-tab-sync.spec.ts | Updates tests to cover syncing the new metadata field. |
| packages/playground/personal-wp/src/lib/personalwp/my-apps.ts | Adds shared blueprint constants + helpers for my-apps. |
| packages/playground/personal-wp/src/lib/personalwp/my-apps.spec.ts | Adds tests for blueprint URL and plugin-file check. |
| packages/playground/personal-wp/src/components/playground-viewport/index.tsx | Adds auto-migration logic to install my-apps and persist a marker. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
45fb582 to
94fb894
Compare
Member
Author
|
Addressed the Copilot review comments:
Re-ran:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Why?
Older Personal WP sites predate the default my-apps plugin. This equips those sites without reinstalling when users already have the plugin.
Testing