Closed Bug 2008197 Opened 5 months ago Closed 1 month ago

Disclosure button expanded/collapsed state not programmatically defined (Customize button)

Categories

(Firefox :: New Tab Page, defect)

Firefox 148
defect

Tracking

()

RESOLVED FIXED
152 Branch
Accessibility Severity s3
Tracking Status
firefox152 --- fixed

People

(Reporter: john.northup, Assigned: sameekshadalvi7)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(2 files)

Steps to Reproduce

Inspect the Customize button.

Expected Behavior

The aria-expanded (true/false) attribute is present and accurately represents the state of the disclosure associated with the button.

Actual Behavior

The aria-expanded attribute is not present.

User Impact

AT users do not know whether a disclosure is expanded or collasped when focus lands on the button that activates it. Users also may be unaware that the button operates a disclosure.

WCAG 2.2 References

Recommendations

Apply the aria-expanded attribute (true/false) to the buttons. This attribute conveys both the state of the disclosure and that the button operates a disclosure.

Testing Environment

Any

Assistive Technology Used

Any

Code Pointers

<button class="personalize-button personalize-animate-enter-done" data-l10n-id="newtab-customize-panel-icon-button" title="Customize this page">

Further Reference

Blocks: 2004739
Keywords: access

Reproduced with Firefox 148.0a1 (2025-12-31) on macOS 15 and Windows 10.
Marking this issue as new for engineering input.
Thank you!

Status: UNCONFIRMED → NEW
Ever confirmed: true

Thank you for the bug report!
It is also recommended to add aria-haspopup="dialog" to this button to indicate the Settings dialog opening, when activated.

Accessibility Severity: --- → s3

Assigning the Severity value to align with the Accessibility severity, per discussions with :thecount and :marco

Severity: -- → S3

Hi, I would like to work on this bug. I was able to reproduce the issue. I checked the code and saw that aria-haspopup="dialog" is already present on the button as suggested in Comment 3. But aria-expanded is missing. I will start working on it and submit the patch shortly.

Assignee: nobody → sameekshadalvi7
Status: NEW → ASSIGNED
Pushed by sdowne@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/972fb1becbdb https://hg.mozilla.org/integration/autoland/rev/bdd0cd01ce36 Add aria-expanded attribute to Customize Menu button. r=home-newtab-reviewers,thecount
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: