Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Update Akamai.xml#7281

Closed
gloomy-ghost wants to merge 4 commits into
EFForg:masterfrom
gloomy-ghost:gloomy-ghost-akamai
Closed

Update Akamai.xml#7281
gloomy-ghost wants to merge 4 commits into
EFForg:masterfrom
gloomy-ghost:gloomy-ghost-akamai

Conversation

@gloomy-ghost

Copy link
Copy Markdown
Collaborator

Add a248.e.akamai.net
Close #6007

@gloomy-ghost gloomy-ghost force-pushed the gloomy-ghost-akamai branch 2 times, most recently from 8ae31d7 to 3e7798e Compare October 6, 2016 01:10
  Add a248.e.akamai.net
    Close EFForg#6007
  Remove exclusion for [\w_-]+-(f|i|s|lh|vh)
@gloomy-ghost

Copy link
Copy Markdown
Collaborator Author

It's hard to refactor this ruleset since lots of subdomains are invisible for search engines.

@jeremyn

jeremyn commented Oct 6, 2016

Copy link
Copy Markdown
Contributor

I'm concerned about you removing the bug-fix exclusions like <exclusion pattern="^http://zynga\d-a.akamaihd\.net/" />. According to the Tor project link there, it was added to fix a bug related to a game called "Slingo". Have you tested that, for example, Slingo still works?

@gloomy-ghost

Copy link
Copy Markdown
Collaborator Author

I didn't mean to remove it, but it didn't have a testing URL when I was editing the ruleset. I got a testing URL http://zynga1-a.akamaihd.net/castleville/67866/gameSettings.xml via Google, and found that it supports https.

I'm unable to register an account on Slingo (the server always responds 400 for unknown reasons), however It would be great if you could try to test it.

@jeremyn

jeremyn commented Oct 7, 2016

Copy link
Copy Markdown
Contributor

I'm similarly concerned about removing the other bug-fix exclusion related to https://lists.eff.org/pipermail/https-everywhere-rules/2012-October/001322.html .

Can you reduce your changes to only the things you want to change? The tests might fail but at least we can see what you really want to do. Maybe we can figure something else out.

@gloomy-ghost

gloomy-ghost commented Oct 7, 2016

Copy link
Copy Markdown
Collaborator Author
ERROR src/chrome/content/rules/Akamai.xml: Not enough tests (5 vs 6) for <Exclusion pattern '^http://[\w_-]+-(?:f|i|s|lh|vh)\.akamaihd\.net/'>
ERROR src/chrome/content/rules/Akamai.xml: Not enough tests (0 vs 1) for <Exclusion pattern '^http://zynga\d-a.akamaihd\.net/'>

Before we start finding more tests, notice that the tests are all accessible in https since the certificate has DNS Name=*.akamaihd.net

@J0WI

J0WI commented Feb 19, 2017

Copy link
Copy Markdown
Contributor

@gloomy-ghost if it's impossible to find enough test urls this can be added to this whitelist:
https://github.com/EFForg/https-everywhere/blob/master/utils/ruleset-coverage-whitelist.txt

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants