Add the `geventCompatible` launch configuration option by underyx · Pull Request #1699 · microsoft/vscode-python

underyx · 2018-05-16T17:35:14Z

Fixes #127

This pull request:

Has a title summarizes what is changing
Includes a news entry file (remember to thank yourself!)
Has unit tests & code coverage is not adversely affected (within reason) — agreed with @DonJayamanne to not add a test for this
Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release) — untested
Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity) — untested, but there's no file system operations touched

msftclas · 2018-05-16T17:35:25Z

All CLA requirements met.

DonJayamanne

We're missing code to create environment variable.
@brettcannon please review messages.

DonJayamanne · 2018-05-16T19:41:32Z

@@ -0,0 +1,2 @@
+Add the `geventCompatible` launch configuration option,
+to make the experimental Python debugger work with projects using gevent's monkey patching.


I'd change this to:
Add geventCompatible launch configuration option to enable debugging of gevent monkey patched code.

DonJayamanne · 2018-05-16T19:44:08Z

 export interface AdditionalLaunchDebugOptions {
    redirectOutput?: boolean;
    django?: boolean;
+    geventCompatible?: boolean;


rename property to gevent

DonJayamanne · 2018-05-16T19:44:26Z

    "python.snippet.launch.flask.description": "Debug a Flask Application",
    "python.snippet.launch.flaskOld.label": "Python: Flask (0.10.x or earlier)",
    "python.snippet.launch.flaskOld.description": "Debug an older styled Flask Application",
+    "python.snippet.launch.gevent.label": "Python: Gevent-compatible",


remove the word -compatible

DonJayamanne · 2018-05-16T19:45:36Z

                            },
+                            "geventCompatible": {
+                                "type": "boolean",
+                                "description": "Make the debugger compatible with gevent monkey-patching.",


Please change to Enable debugging of gevent monkey-patched code

codecov · 2018-05-16T19:46:57Z

Codecov Report

Merging #1699 into master will decrease coverage by 2.96%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master    #1699      +/-   ##
==========================================
- Coverage   74.44%   71.48%   -2.97%     
==========================================
  Files         282      277       -5     
  Lines       13253    13016     -237     
  Branches     2382     2345      -37     
==========================================
- Hits         9866     9304     -562     
- Misses       3257     3576     +319     
- Partials      130      136       +6

Impacted Files	Coverage Δ
src/client/debugger/Common/Contracts.ts	`100% <ø> (ø)`	⬆️
src/client/common/variables/environment.ts	`92.45% <100%> (-4.92%)`	⬇️
src/client/debugger/DebugClients/helper.ts	`92.85% <66.66%> (-3.3%)`	⬇️
.../unittests/common/services/configSettingService.ts	`6.81% <0%> (-85.02%)`	⬇️
src/client/unittests/display/main.ts	`5.88% <0%> (-81.62%)`	⬇️
src/client/unittests/configuration.ts	`19.51% <0%> (-76.79%)`	⬇️
...preter/locators/services/windowsRegistryService.ts	`19.48% <0%> (-74.11%)`	⬇️
src/client/providers/symbolProvider.ts	`23.33% <0%> (-59.36%)`	⬇️
...ttests/common/managers/testConfigurationManager.ts	`10.63% <0%> (-25.73%)`	⬇️
src/client/common/installer/productInstaller.ts	`59.18% <0%> (-18.5%)`	⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f48a19...3968ec1. Read the comment docs.

This makes the experimental Python debugger work with projects using gevent's monkey patching. Closes #127

underyx · 2018-05-16T20:02:30Z

Inline comments all resolved
We're missing code to create environment variable

Yup, my bad, messed up the commit split as I was fixing tslint errors; now fixed

Thanks for the comments!

underyx · 2018-05-25T14:46:19Z

@brettcannon FYI I think this is waiting for you only.

brettcannon · 2018-05-28T18:59:54Z

Labels seem fine to me. Now we're just waiting on @DonJayamanne to give the all-clear and to merge!

Fix tslint errors brought in by typescript@2.8.3

fd3c316

underyx mentioned this pull request May 16, 2018

Document how to debug gevent apps #1700

Closed

DonJayamanne requested changes May 16, 2018

View reviewed changes

Add the geventCompatible launch configuration option

54f8b7f

This makes the experimental Python debugger work with projects using gevent's monkey patching. Closes #127

DonJayamanne added this to the June 2018 milestone Jun 5, 2018

Merge branch 'master' into 127-gevent-debugging

3968ec1

DonJayamanne approved these changes Jun 5, 2018

View reviewed changes

DonJayamanne merged commit b1055e1 into microsoft:master Jun 7, 2018

brettcannon mentioned this pull request Jun 7, 2018

Document gevent-related settings for Python extension microsoft/vscode-docs#1672

Closed

lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add the `geventCompatible` launch configuration option#1699

Add the `geventCompatible` launch configuration option#1699
DonJayamanne merged 3 commits into
microsoft:masterfrom
underyx:127-gevent-debugging

underyx commented May 16, 2018

Uh oh!

msftclas commented May 16, 2018 •

edited

Loading

Uh oh!

DonJayamanne left a comment

Uh oh!

DonJayamanne May 16, 2018

Uh oh!

DonJayamanne May 16, 2018

Uh oh!

DonJayamanne May 16, 2018

Uh oh!

DonJayamanne May 16, 2018

Uh oh!

codecov Bot commented May 16, 2018 •

edited

Loading

Uh oh!

underyx commented May 16, 2018 •

edited

Loading

Uh oh!

underyx commented May 25, 2018

Uh oh!

brettcannon commented May 28, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -0,0 +1,2 @@
		Add the `geventCompatible` launch configuration option,
		to make the experimental Python debugger work with projects using gevent's monkey patching.

Conversation

underyx commented May 16, 2018

Uh oh!

msftclas commented May 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DonJayamanne left a comment

Choose a reason for hiding this comment

Uh oh!

DonJayamanne May 16, 2018

Choose a reason for hiding this comment

Uh oh!

DonJayamanne May 16, 2018

Choose a reason for hiding this comment

Uh oh!

DonJayamanne May 16, 2018

Choose a reason for hiding this comment

Uh oh!

DonJayamanne May 16, 2018

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented May 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

underyx commented May 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

underyx commented May 25, 2018

Uh oh!

brettcannon commented May 28, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

msftclas commented May 16, 2018 •

edited

Loading

codecov Bot commented May 16, 2018 •

edited

Loading

underyx commented May 16, 2018 •

edited

Loading