Skip to content

eof: Optimize EOF validation by using std::move#1036

Merged
chfast merged 1 commit into
masterfrom
eof/optimize_validation_alloc
Sep 30, 2024
Merged

eof: Optimize EOF validation by using std::move#1036
chfast merged 1 commit into
masterfrom
eof/optimize_validation_alloc

Conversation

@chfast

@chfast chfast commented Sep 27, 2024

Copy link
Copy Markdown
Member

Optimize validate_instructions() by using std::move on arguments to returned InstructionValidationResult.

@chfast chfast requested a review from gumb0 September 27, 2024 21:53
@codecov

codecov Bot commented Sep 27, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.21%. Comparing base (46dc5ee) to head (7d633bc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1036   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files         153      153           
  Lines       15933    15934    +1     
=======================================
+ Hits        15011    15012    +1     
  Misses        922      922           
Flag Coverage Δ
eof_execution_spec_tests 17.53% <100.00%> (+<0.01%) ⬆️
ethereum_tests 27.34% <100.00%> (+<0.01%) ⬆️
ethereum_tests_silkpre 19.15% <0.00%> (ø)
execution_spec_tests 20.45% <0.00%> (-0.01%) ⬇️
unittests 89.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/evmone/eof.cpp 85.71% <100.00%> (+0.02%) ⬆️

@chfast chfast added the EOF label Sep 28, 2024
Optimize `validate_instructions()` by using `std::move` on arguments to
returned `InstructionValidationResult`.
@chfast chfast force-pushed the eof/optimize_validation_alloc branch from bac8cc3 to 7d633bc Compare September 30, 2024 16:24
@chfast chfast merged commit 8e4a055 into master Sep 30, 2024
@chfast chfast deleted the eof/optimize_validation_alloc branch September 30, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants