Skip to content

Introduce TransactionProperties#1098

Merged
chfast merged 1 commit into
masterfrom
tx_props
Jan 9, 2025
Merged

Introduce TransactionProperties#1098
chfast merged 1 commit into
masterfrom
tx_props

Conversation

@chfast

@chfast chfast commented Jan 9, 2025

Copy link
Copy Markdown
Member

This introduces struct TransactionProperties for values computed during the transaction validation needed for transaction execution.

Later, the EIP-7623 will one more field to it.

@chfast chfast requested a review from gumb0 January 9, 2025 12:02
@codecov

codecov Bot commented Jan 9, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.31%. Comparing base (9400148) to head (7a58bda).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1098       +/-   ##
===========================================
+ Coverage   30.86%   94.31%   +63.44%     
===========================================
  Files         159      159               
  Lines       17224    17225        +1     
===========================================
+ Hits         5317    16246    +10929     
+ Misses      11907      979    -10928     
Flag Coverage Δ
eof_execution_spec_tests 23.62% <88.88%> (+<0.01%) ⬆️
ethereum_tests 26.64% <88.88%> (+<0.01%) ⬆️
ethereum_tests_silkpre 18.94% <87.50%> (+0.01%) ⬆️
execution_spec_tests 20.97% <88.88%> (+<0.01%) ⬆️
unittests 89.06% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/state/state.cpp 99.59% <100.00%> (+0.40%) ⬆️
test/state/state.hpp 100.00% <ø> (ø)
test/state/test_state.cpp 100.00% <100.00%> (+1.69%) ⬆️
test/state/transaction.hpp 100.00% <ø> (ø)
test/unittests/state_tx_test.cpp 100.00% <100.00%> (+100.00%) ⬆️

... and 108 files with indirect coverage changes

@chfast chfast force-pushed the tx_props branch 2 times, most recently from f150f3b to b0afb91 Compare January 9, 2025 12:38
Comment thread test/state/test_state.cpp Outdated
This introduces `struct TransactionProperties` for values computed
during the transaction validation needed for transaction execution.

Later, the EIP-7623 will one more field to it.
@chfast chfast enabled auto-merge (squash) January 9, 2025 13:30
@chfast chfast merged commit bfbb6ec into master Jan 9, 2025
@chfast chfast deleted the tx_props branch January 9, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants