Skip to content

Support EIP-7691: Blob throughput increase#1118

Merged
pdobacz merged 3 commits into
masterfrom
7691
Jan 29, 2025
Merged

Support EIP-7691: Blob throughput increase#1118
pdobacz merged 3 commits into
masterfrom
7691

Conversation

@pdobacz

@pdobacz pdobacz commented Jan 27, 2025

Copy link
Copy Markdown
Member

Implements EIP-7691. It seems only 7702 is missing (once spec stabilizes) from passing EEST devnet-5/6 tests

The parametrization of blob gas schedule with rev led to quite a bit of fallout...

@pdobacz pdobacz requested a review from chfast January 27, 2025 15:25
@codecov

codecov Bot commented Jan 27, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.29%. Comparing base (9d28979) to head (85a56fb).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1118   +/-   ##
=======================================
  Coverage   94.29%   94.29%           
=======================================
  Files         159      159           
  Lines       17325    17343   +18     
=======================================
+ Hits        16337    16354   +17     
- Misses        988      989    +1     
Flag Coverage Δ
eof_execution_spec_tests 15.91% <14.63%> (-0.01%) ⬇️
ethereum_tests 26.89% <29.26%> (+<0.01%) ⬆️
ethereum_tests_silkpre 18.96% <16.00%> (-0.02%) ⬇️
execution_spec_tests 21.53% <29.26%> (+0.42%) ⬆️
unittests 89.05% <93.90%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/blockchaintest/blockchaintest_loader.cpp 98.91% <100.00%> (+0.01%) ⬆️
test/blockchaintest/blockchaintest_runner.cpp 80.62% <100.00%> (ø)
test/state/block.cpp 100.00% <100.00%> (ø)
test/state/block.hpp 66.66% <ø> (-33.34%) ⬇️
test/statetest/statetest.hpp 87.50% <ø> (-0.74%) ⬇️
test/statetest/statetest_loader.cpp 98.18% <100.00%> (+<0.01%) ⬆️
test/statetest/statetest_runner.cpp 97.14% <100.00%> (ø)
test/t8n/t8n.cpp 87.64% <100.00%> (ø)
test/unittests/state_block_test.cpp 100.00% <100.00%> (ø)
test/unittests/state_transition.cpp 98.49% <100.00%> (ø)
... and 4 more

@chfast chfast left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to split out the BlockInfo change?

},
"post": {},
"post": {
"Cancun": []

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do EEST have multiple entries here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, no, it seems "Cancun" and "Prague" keys would get split into two tests. Do you think this warrants removing the tests: Support varying BlockInfo in statetests? And just using the first entry and asserting there is only one?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think the change is fine. We rather should push for the test format update long term.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also one change I have in mind: we should split BlockInfo into multiple structs: data from tests, computed values, data needed for EVM execution.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think the change is fine. We rather should push for the test format update long term.

Meanwhile, I've tried it. It is only marginally smaller, not worth it

There is also one change I have in mind: we should split BlockInfo into multiple structs: data from tests, computed values, data needed for EVM execution.

I presume not in this PR?

Do you want to split out the BlockInfo change?

I was not planning to squash it, so it remains as a separate commit, ok?

Comment thread test/blockchaintest/blockchaintest_loader.cpp Outdated
Comment thread test/blockchaintest/blockchaintest_loader.cpp Outdated
@pdobacz pdobacz enabled auto-merge January 29, 2025 09:35
@pdobacz pdobacz merged commit 615e939 into master Jan 29, 2025
@pdobacz pdobacz deleted the 7691 branch January 29, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants