Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1118 +/- ##
=======================================
Coverage 94.29% 94.29%
=======================================
Files 159 159
Lines 17325 17343 +18
=======================================
+ Hits 16337 16354 +17
- Misses 988 989 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
left a comment
There was a problem hiding this comment.
Do you want to split out the BlockInfo change?
| }, | ||
| "post": {}, | ||
| "post": { | ||
| "Cancun": [] |
There was a problem hiding this comment.
Do EEST have multiple entries here?
There was a problem hiding this comment.
Hm, no, it seems "Cancun" and "Prague" keys would get split into two tests. Do you think this warrants removing the tests: Support varying BlockInfo in statetests? And just using the first entry and asserting there is only one?
There was a problem hiding this comment.
No, I think the change is fine. We rather should push for the test format update long term.
There was a problem hiding this comment.
There is also one change I have in mind: we should split BlockInfo into multiple structs: data from tests, computed values, data needed for EVM execution.
There was a problem hiding this comment.
No, I think the change is fine. We rather should push for the test format update long term.
Meanwhile, I've tried it. It is only marginally smaller, not worth it
There is also one change I have in mind: we should split BlockInfo into multiple structs: data from tests, computed values, data needed for EVM execution.
I presume not in this PR?
Do you want to split out the BlockInfo change?
I was not planning to squash it, so it remains as a separate commit, ok?
Implements EIP-7691. It seems only 7702 is missing (once spec stabilizes) from passing EEST devnet-5/6 tests
The parametrization of blob gas schedule with
revled to quite a bit of fallout...