Skip to content

eof: Cleanup stack height validation for next instruction#1144

Merged
chfast merged 1 commit into
masterfrom
eof/visit_next
Feb 26, 2025
Merged

eof: Cleanup stack height validation for next instruction#1144
chfast merged 1 commit into
masterfrom
eof/visit_next

Conversation

@chfast

@chfast chfast commented Feb 26, 2025

Copy link
Copy Markdown
Member

The stack height check for the next instruction is always successful. Downgrade the check of the result of the visit_successor in this case to assert.

The stack height check for the next instruction is always successful.
Downgrade the check of the result of the `visit_successor` in this case
to assert.
@chfast chfast added the EOF label Feb 26, 2025
@chfast chfast requested review from gumb0 and pdobacz February 26, 2025 09:37
@codecov

codecov Bot commented Feb 26, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.50%. Comparing base (0be7b16) to head (960bb5f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1144   +/-   ##
=======================================
  Coverage   94.50%   94.50%           
=======================================
  Files         167      167           
  Lines       18193    18193           
=======================================
+ Hits        17193    17194    +1     
+ Misses       1000      999    -1     
Flag Coverage Δ
eof_execution_spec_tests 15.34% <100.00%> (+<0.01%) ⬆️
ethereum_tests 28.32% <100.00%> (+<0.01%) ⬆️
ethereum_tests_silkpre 20.83% <0.00%> (ø)
execution_spec_tests 21.10% <0.00%> (ø)
unittests 89.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/evmone/eof.cpp 86.06% <100.00%> (+0.17%) ⬆️

@chfast chfast self-assigned this Feb 26, 2025
@chfast chfast merged commit 2e8feb4 into master Feb 26, 2025
@chfast chfast deleted the eof/visit_next branch February 26, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants