Check for topic when parsing deposit contract logs#1152
Merged
Conversation
1740931 to
14f4a2b
Compare
|
LGTM. This is how all the other clients approach it. |
chfast
reviewed
Mar 5, 2025
chfast
left a comment
Member
There was a problem hiding this comment.
Can we have a regression test for this?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1152 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 168 168
Lines 18246 18256 +10
=======================================
+ Hits 17251 17261 +10
Misses 995 995
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
chfast
requested changes
Mar 10, 2025
chfast
requested changes
Mar 10, 2025
14f4a2b to
e9ba681
Compare
chfast
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out on Sepolia deposit contract is different and can emit other logs (ERC20's
Transfer)