precompiles: Optimize EC point multiplication#1166
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1166 +/- ##
===========================================
+ Coverage 31.23% 94.48% +63.25%
===========================================
Files 169 169
Lines 18020 18014 -6
===========================================
+ Hits 5628 17021 +11393
+ Misses 12392 993 -11399
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
rodiazet
approved these changes
Mar 14, 2025
Simplify and optimize the procedure for EC point multiplication. This reduced EC point multiplication time by 30%. ``` Comparing o/ec to o/ec-mulopt Benchmark Time CPU Time Old Time New CPU Old CPU New ------------------------------------------------------------------------------------------------------------------------------------------------------- precompile<PrecompileId::ecrecover, evmmax_cpp>_mean -0.2961 -0.2960 312197 219765 312126 219741 precompile<PrecompileId::ecmul, evmmax_cpp>_mean -0.3179 -0.3180 144903 98842 144882 98814 ```
ad6a7aa to
72ef246
Compare
gumb0
pushed a commit
that referenced
this pull request
Mar 20, 2025
Simplify and optimize the procedure for EC point multiplication. This reduced EC point multiplication time by 30%. ``` Comparing o/ec to o/ec-mulopt Benchmark Time CPU Time Old Time New CPU Old CPU New ------------------------------------------------------------------------------------------------------------------------------------------------------- precompile<PrecompileId::ecrecover, evmmax_cpp>_mean -0.2961 -0.2960 312197 219765 312126 219741 precompile<PrecompileId::ecmul, evmmax_cpp>_mean -0.3179 -0.3180 144903 98842 144882 98814 ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify and optimize the procedure for EC point multiplication. This reduced EC point multiplication time by 30%.