feat(GcodePreview): improved arc support#1846
Merged
pedrolamas merged 1 commit intoMay 19, 2026
Merged
Conversation
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves G-code preview arc handling by tracking active arc planes and adding support for G2/G3 arcs that use the R radius parameter.
Changes:
- Tracks modal arc plane selection via
G17,G18, andG19during parsing. - Adds
ArcPlanetyping and stores the active plane on parsed arc moves. - Renders XY-plane
Rarcs as SVG arcs, while representing XZ/YZ-plane arcs as straight XY-projection lines.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/workers/parseGcode.ts |
Parses modal arc plane commands and attaches the active plane to arc moves. |
src/util/gcode-preview.ts |
Adds R-parameter arc rendering and fallback handling for non-XY planes. |
src/store/gcodePreview/types.ts |
Adds ArcPlane and records it on ArcMove. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved
G2andG3command support, to includeRargument, andG17,G18, andG19multi-planar handling.The 'xy' plane (
G17) is the currently handled case, for 'xz' and 'yz' (G18andG19), we just represent it as line from the origin point to the destination.