fix: vue-json-viewer import#1848
Merged
Merged
Conversation
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Diagnostics “Metrics Explorer” / state viewer rendering regression introduced by the Vite 8 (Rolldown) upgrade, where importing vue-json-viewer returns a module wrapper instead of the Vue component.
Changes:
- Switch
vue-json-viewerimport to a module import and manually unwrap the default export when present. - Keep the component registration compatible with both CJS/UMD and ESM-style exports under Rolldown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we upgraded to Vite 8 in d293289, that caused any UMD import to fail as Rolldown (Vite 8) doesn't auto-unwrap __esModule CJS modules.
This fixes the problem by adding a manual unwrap.
Fixed #1847