feat(Thermals): highlight series on mouse hover#1858
Merged
pedrolamas merged 1 commit intoMay 31, 2026
Merged
Conversation
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds mouse-hover-driven series emphasis to the thermal chart. Hovering a row in the temperature table or a line on the chart highlights the corresponding series (and its target/power/speed siblings) while fading others, using ECharts' built-in focus: 'series' and highlight/downplay actions.
Changes:
- Switch per-series
emphasisfrom manuallineStyle.widthtofocus: 'series'inThermalChart, and exposehighlightSeries(key)/downplaySeries()that dispatch the matching ECharts actions for the base key plus its#target/#power/#speedsiblings. - Emit
highlightChartSeries/downplayChartSeriesfrom heater/fan/sensor table rows onmouseenter/mouseleaveinTemperatureTargets. - Forward those events from
TemperatureCardto theThermalChartref, guarded bychartVisible(mirroring the existingupdateChartSelectedLegendsforwarder).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/widgets/thermals/ThermalChart.vue | Use focus: 'series' for emphasis; add imperative highlightSeries/downplaySeries methods that dispatch ECharts highlight/downplay including related sub-series. |
| src/components/widgets/thermals/TemperatureTargets.vue | Add mouseenter/mouseleave handlers on heater, fan, and sensor rows that emit highlight/downplay events with the item key. |
| src/components/widgets/thermals/TemperatureCard.vue | Bridge child hover events to the thermal chart ref, gated on chartVisible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables series highlighting on the thermal chart by hovering the series directly on the chart or hovering the item in the thermal entries list.
Screen Capture
Video.mp4
Resolves #1536