Skip to content

feat(Thermals): highlight series on mouse hover#1858

Merged
pedrolamas merged 1 commit into
fluidd-core:developfrom
pedrolamas:pedrolamas/thermal-series-highlight
May 31, 2026
Merged

feat(Thermals): highlight series on mouse hover#1858
pedrolamas merged 1 commit into
fluidd-core:developfrom
pedrolamas:pedrolamas/thermal-series-highlight

Conversation

@pedrolamas

Copy link
Copy Markdown
Member

Enables series highlighting on the thermal chart by hovering the series directly on the chart or hovering the item in the thermal entries list.

Screen Capture

Video.mp4

Resolves #1536

Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
@pedrolamas pedrolamas added this to the 1.37.1 milestone May 31, 2026
@pedrolamas pedrolamas requested a review from Copilot May 31, 2026 13:56
@pedrolamas pedrolamas added the FR - Enhancement New feature or request label May 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds mouse-hover-driven series emphasis to the thermal chart. Hovering a row in the temperature table or a line on the chart highlights the corresponding series (and its target/power/speed siblings) while fading others, using ECharts' built-in focus: 'series' and highlight/downplay actions.

Changes:

  • Switch per-series emphasis from manual lineStyle.width to focus: 'series' in ThermalChart, and expose highlightSeries(key) / downplaySeries() that dispatch the matching ECharts actions for the base key plus its #target/#power/#speed siblings.
  • Emit highlightChartSeries / downplayChartSeries from heater/fan/sensor table rows on mouseenter/mouseleave in TemperatureTargets.
  • Forward those events from TemperatureCard to the ThermalChart ref, guarded by chartVisible (mirroring the existing updateChartSelectedLegends forwarder).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/components/widgets/thermals/ThermalChart.vue Use focus: 'series' for emphasis; add imperative highlightSeries/downplaySeries methods that dispatch ECharts highlight/downplay including related sub-series.
src/components/widgets/thermals/TemperatureTargets.vue Add mouseenter/mouseleave handlers on heater, fan, and sensor rows that emit highlight/downplay events with the item key.
src/components/widgets/thermals/TemperatureCard.vue Bridge child hover events to the thermal chart ref, gated on chartVisible.

@pedrolamas pedrolamas changed the title feat(thermals): highlight series on mouse hover feat(Thermals): highlight series on mouse hover May 31, 2026
@pedrolamas pedrolamas merged commit 46fa66c into fluidd-core:develop May 31, 2026
5 checks passed
@pedrolamas pedrolamas deleted the pedrolamas/thermal-series-highlight branch May 31, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FR - Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Highlight line in thermal chart on rollover

2 participants