feat: add pause functionality in ThermalChart#1859
Merged
pedrolamas merged 2 commits intoMay 31, 2026
Conversation
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds pause/resume support to the ThermalChart so users can stop the live-scrolling data for inspection, then resume back to the latest “live” dataset. It also refactors vue-echarts update-options / init-options bindings to use stable object references to avoid unnecessary chart dispose/re-init or state resets on component re-renders.
Changes:
- Add a pause/resume toggle overlay to
ThermalChartand prevent dataset updates while paused (with a refresh on resume). - Use stable, frozen
updateOptions/initOptionsobject references in chart components to prevent vue-echarts re-init/reset behavior on re-renders. - Adjust
ThermalChartcontainer styling to support the overlay positioning.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/widgets/thermals/ThermalChart.vue | Adds pause/resume UI + state gating for dataset updates; stabilizes vue-echarts option object references; positions overlay via relative container. |
| src/components/widgets/bedmesh/BedMeshChart.vue | Stabilizes vue-echarts option object references to avoid re-init and preserve 3D camera state across re-renders. |
| src/components/ui/AppChart.vue | Stabilizes vue-echarts option object references to avoid re-init/re-apply behavior that can wipe imperatively-set datasets. |
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Comment on lines
+23
to
+27
| <v-btn | ||
| v-bind="attrs" | ||
| icon | ||
| small | ||
| tabindex="-1" |
Member
Author
There was a problem hiding this comment.
Leaving as is for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to pause/resume the thermal chart. When resuming, it will show the latest "live" data available.
Also refactors chart options handling to use stable references so component re-renders don't cause vue-echarts to dispose/re-init the chart or re-apply the options.
Screenshot
Video.mp4
Resolves #1537