Skip to content

feat: warn of very old Moonraker#1870

Merged
pedrolamas merged 2 commits into
fluidd-core:developfrom
pedrolamas:pedrolamas/old-moonraker
Jun 5, 2026
Merged

feat: warn of very old Moonraker#1870
pedrolamas merged 2 commits into
fluidd-core:developfrom
pedrolamas:pedrolamas/old-moonraker

Conversation

@pedrolamas

Copy link
Copy Markdown
Member

When server.connection.identify returns JSON-RPC -32601 ("Method not found"), the old code transitioned the socket to authenticating state, dead-ending users on a login screen that an old Moonraker can't satisfy.

This change detects -32601 specifically and instead continues loading the app unauthenticated through the normal bootstrap to ready path, while surfacing both a transient flash warning and a persistent notification telling the user to update Moonraker.

Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
@pedrolamas pedrolamas added this to the 1.37.2 milestone Jun 5, 2026
@pedrolamas pedrolamas requested a review from Copilot June 5, 2026 08:38
@pedrolamas pedrolamas added the FR - Enhancement New feature or request label Jun 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the socket identify flow to handle very old Moonraker instances that don’t implement server.connection.identify, avoiding an auth “dead-end” while still warning the user and surfacing an update prompt.

Changes:

  • Treat JSON-RPC -32601 from server.connection.identify as “very old Moonraker” and proceed with the normal bootstrap-to-ready path.
  • Emit a transient warning toast and add a persistent notification pointing users to /settings#versions.
  • Deduplicate the Moonraker min-version notification logic via a shared server/notifyOldMoonraker action.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/store/socket/actions.ts Adds special handling for JSON-RPC -32601 during identify to continue bootstrapping and warn users instead of forcing authenticating.
src/store/server/actions.ts Introduces notifyOldMoonraker and reuses it from the min-version check for consistent persistent warnings.

Comment thread src/store/server/actions.ts
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@pedrolamas pedrolamas merged commit efdcdc5 into fluidd-core:develop Jun 5, 2026
4 checks passed
@pedrolamas pedrolamas deleted the pedrolamas/old-moonraker branch June 5, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FR - Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants