feat: warn of very old Moonraker#1870
Merged
pedrolamas merged 2 commits intoJun 5, 2026
Merged
Conversation
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the socket identify flow to handle very old Moonraker instances that don’t implement server.connection.identify, avoiding an auth “dead-end” while still warning the user and surfacing an update prompt.
Changes:
- Treat JSON-RPC
-32601fromserver.connection.identifyas “very old Moonraker” and proceed with the normal bootstrap-to-readypath. - Emit a transient warning toast and add a persistent notification pointing users to
/settings#versions. - Deduplicate the Moonraker min-version notification logic via a shared
server/notifyOldMoonrakeraction.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/store/socket/actions.ts | Adds special handling for JSON-RPC -32601 during identify to continue bootstrapping and warn users instead of forcing authenticating. |
| src/store/server/actions.ts | Introduces notifyOldMoonraker and reuses it from the min-version check for consistent persistent warnings. |
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
server.connection.identifyreturns JSON-RPC -32601 ("Method not found"), the old code transitioned the socket toauthenticatingstate, dead-ending users on a login screen that an old Moonraker can't satisfy.This change detects -32601 specifically and instead continues loading the app unauthenticated through the normal bootstrap to
readypath, while surfacing both a transient flash warning and a persistent notification telling the user to update Moonraker.