Skip to content

feat: adds support for Moonraker file roots details#1881

Merged
pedrolamas merged 2 commits into
fluidd-core:developfrom
pedrolamas:pedrolamas/moonraker-files-roots
Jun 17, 2026
Merged

feat: adds support for Moonraker file roots details#1881
pedrolamas merged 2 commits into
fluidd-core:developfrom
pedrolamas:pedrolamas/moonraker-files-roots

Conversation

@pedrolamas

Copy link
Copy Markdown
Member

Adds support for Moonraker's server.files.roots service call.

This code is not currently in use but serves as a base for future improvements.

Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
@pedrolamas pedrolamas added this to the 1.37.2 milestone Jun 16, 2026
@pedrolamas pedrolamas requested a review from Copilot June 16, 2026 22:55
@pedrolamas pedrolamas added the FR - Enhancement New feature or request label Jun 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds baseline support for Moonraker’s server.files.roots JSON-RPC call by introducing typings, a Vuex state slot + getter for root details, and a SocketActions helper to fetch/store root metadata for later UI use.

Changes:

  • Added Moonraker typings for server.files.roots response items including root path.
  • Extended the files Vuex module to store roots and expose a getRootDetails getter.
  • Added SocketActions.serverFilesRoots() with a dedicated wait key (Waits.onFileSystemRoots).

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/typings/moonraker.file_manager.d.ts Adds typings for the server.files.roots response and root path info.
src/store/files/types.ts Extends FilesState with roots and relaxes currentPaths value type.
src/store/files/state.ts Initializes new roots state field.
src/store/files/mutations.ts Adds mutation to persist roots response into state.
src/store/files/getters.ts Adds getter to retrieve root details by root name.
src/store/files/actions.ts Adds action handler to store server.files.roots results.
src/globals.ts Adds a wait key for root details fetch.
src/api/socketActions.ts Adds a socket action wrapper for server.files.roots.

Comment thread src/store/files/actions.ts
Spread the response array before persisting so the non-enumerable
__request__ metadata is not kept on state.roots, matching the
onServerFilesListRoot convention.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated no new comments.

@pedrolamas pedrolamas merged commit ea60d78 into fluidd-core:develop Jun 17, 2026
4 checks passed
@pedrolamas pedrolamas deleted the pedrolamas/moonraker-files-roots branch June 17, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FR - Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants