Skip to content

refactor: logout notification handling#1882

Merged
pedrolamas merged 1 commit into
fluidd-core:developfrom
pedrolamas:pedrolamas/refactor-logout-notification
Jun 17, 2026
Merged

refactor: logout notification handling#1882
pedrolamas merged 1 commit into
fluidd-core:developfrom
pedrolamas:pedrolamas/refactor-logout-notification

Conversation

@pedrolamas

Copy link
Copy Markdown
Member

Refactors the user logout notification to simplify and centralize it under the auth store module.

Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
@pedrolamas pedrolamas added this to the 1.37.2 milestone Jun 17, 2026
@pedrolamas pedrolamas requested a review from Copilot June 17, 2026 13:32
@pedrolamas pedrolamas added the Code - Optimizations Everything that relates to code optimizations! label Jun 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors Moonraker “user logged out” notification handling by moving the logout cleanup/transition logic out of the socket store and into the auth store module, keeping session invalidation handling centralized in auth/logout.

Changes:

  • socket/notifyUserLoggedOut now delegates to auth/onUserLoggedOut.
  • Added auth/onUserLoggedOut action to run a plain logout() when Moonraker invalidates the session.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/store/socket/actions.ts Delegates logout notification handling to the auth module.
src/store/auth/actions.ts Adds onUserLoggedOut action that routes Moonraker invalidation into the existing logout flow.

Comment thread src/store/socket/actions.ts
@pedrolamas pedrolamas force-pushed the pedrolamas/refactor-logout-notification branch 2 times, most recently from e93db62 to 80ab241 Compare June 17, 2026 13:40
@pedrolamas pedrolamas requested a review from Copilot June 17, 2026 13:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@pedrolamas pedrolamas merged commit 6f4d60a into fluidd-core:develop Jun 17, 2026
8 checks passed
@pedrolamas pedrolamas deleted the pedrolamas/refactor-logout-notification branch June 17, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code - Optimizations Everything that relates to code optimizations!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants