refactor: add AppInlineChart component#1889
Merged
pedrolamas merged 4 commits intoJun 22, 2026
Merged
Conversation
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the system widget inline charts to use a new shared AppInlineChart UI component, replacing the dedicated SystemChart wrapper.
Changes:
- Add
AppInlineChartcomponent to standardize inline chart rendering + label/value display. - Update system widget chart components (memory/load/MCU/Klipper/Moonraker) to pass label definitions via a new
labelscomputed property. - Remove the now-redundant
SystemChartcomponent.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/components/widgets/system/SystemMemoryChart.vue | Migrates to AppInlineChart and supplies label metadata for memory usage. |
| src/components/widgets/system/SystemLoadChart.vue | Migrates to AppInlineChart and supplies label metadata for system load (incl. cores suffix). |
| src/components/widgets/system/MoonrakerLoadChart.vue | Migrates to AppInlineChart and supplies label metadata for Moonraker load. |
| src/components/widgets/system/McuLoadChart.vue | Migrates to AppInlineChart and supplies two labels (load + awake). |
| src/components/widgets/system/KlipperLoadChart.vue | Migrates to AppInlineChart and supplies label metadata for Klipper load. |
| src/components/widgets/system/SystemChart.vue | Removed (replaced by AppInlineChart). |
| src/components/ui/AppInlineChart.vue | New shared component that renders an inline chart and derived label/value rows. |
| components.d.ts | Updates global component typing to include AppInlineChart (and regenerated Vuetify typings). |
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
- Drop `inheritAttrs: false`: the root `<v-col>` never forwarded `$attrs`/`$listeners`, so the flag only blocked passthrough. - Treat empty arrays as empty in `isEmpty`, matching AppDataTableRow. - Remove the unused `customGetter` prop and Getter/DefaultGetter types; `suffix` covers every consumer. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new AppInlineChart component for easy inline charts usage across Fluidd.