refactor: drop redundant console sanitize#1890
Merged
pedrolamas merged 1 commit intoJun 23, 2026
Merged
Conversation
Console messages are already sanitized at render via v-safe-html (DOMPurify), and ConsoleItem injects further HTML after the store, so the store-side DOMPurify.sanitize never protected the rendered output. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes redundant console-message sanitization from the Vuex console store, relying on the existing v-safe-html (DOMPurify) sanitization at render time in ConsoleItem, which is where additional HTML is injected.
Changes:
- Drop
DOMPurify.sanitize(...)fromconsole/onAddConsoleEntryandconsole/onGcodeStore. - Keep newline-to-
<br />normalization so console formatting remains consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Console messages are already sanitized at render via
v-safe-html(DOMPurify), andConsoleIteminjects further HTML after the store, so the store-sideDOMPurify.sanitizenever protected the rendered output.