Future annotations#44
Merged
Merged
Conversation
c9d4bf3 to
0818b6a
Compare
Fixed 80 errors:
- docs/conf.py:
2 × UP007 (non-pep604-annotation)
2 × UP037 (quoted-annotation)
1 × I002 (missing-required-import)
- src/doctest_docutils.py:
15 × UP007 (non-pep604-annotation)
2 × UP037 (quoted-annotation)
2 × TC002 (typing-only-third-party-import)
1 × I001 (unsorted-imports)
1 × I002 (missing-required-import)
1 × TC003 (typing-only-standard-library-import)
- src/docutils_compat.py:
2 × UP037 (quoted-annotation)
2 × TC003 (typing-only-standard-library-import)
1 × I002 (missing-required-import)
1 × I001 (unsorted-imports)
- src/gp_libs.py:
1 × I002 (missing-required-import)
- src/linkify_issues.py:
1 × UP007 (non-pep604-annotation)
1 × I002 (missing-required-import)
1 × TC002 (typing-only-third-party-import)
- src/pytest_doctest_docutils.py:
15 × UP037 (quoted-annotation)
8 × UP007 (non-pep604-annotation)
3 × TC003 (typing-only-standard-library-import)
1 × I002 (missing-required-import)
1 × I001 (unsorted-imports)
- tests/conftest.py:
4 × UP007 (non-pep604-annotation)
1 × TC003 (typing-only-standard-library-import)
1 × I002 (missing-required-import)
- tests/test_doctest_docutils.py:
1 × I002 (missing-required-import)
1 × TC003 (typing-only-standard-library-import)
- tests/test_linkify_issues.py:
1 × I002 (missing-required-import)
1 × UP037 (quoted-annotation)
1 × TC002 (typing-only-third-party-import)
1 × TC003 (typing-only-standard-library-import)
1 × I001 (unsorted-imports)
- tests/test_pytest_doctest_docutils.py:
1 × I002 (missing-required-import)
1 × TC002 (typing-only-third-party-import)
Found 225 errors (80 fixed, 145 remaining).
10 files reformatted, 1 file left unchanged
uv run ruff check --select ALL . --fix --unsafe-fixes --preview --show-fixes; uv run ruff format .
b54b823 to
8d3b3ce
Compare
4a9ee78 to
d98816b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 58.91% 60.03% +1.11%
==========================================
Files 10 10
Lines 662 633 -29
==========================================
- Hits 390 380 -10
+ Misses 272 253 -19 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
chore: Support PEP 563
from __future__ import annotationsUsing PEP 563's deferred resolution of annotations avoids the computation cost of symbols we imported solely used for type-checking.
Ruff:
non-pep585-annotation (UP006)non-pep604-annotation (UP007)PEP 563: https://peps.python.org/pep-0563/