Skip to content

Fixed multiple error-dialogs appearing when a lot of nodes are broken#300

Open
MSementsov-Ibk wants to merge 1 commit into
locationtech:masterfrom
MSementsov-Ibk:multi-error-msg-fix
Open

Fixed multiple error-dialogs appearing when a lot of nodes are broken#300
MSementsov-Ibk wants to merge 1 commit into
locationtech:masterfrom
MSementsov-Ibk:multi-error-msg-fix

Conversation

@MSementsov-Ibk

@MSementsov-Ibk MSementsov-Ibk commented Sep 28, 2018

Copy link
Copy Markdown
Contributor

When selecting multiple nodes and creating an invalid geometry and then pressing enter, multiple error dialogs show up.

Signed-off-by: Michael Sementsov michael.sementsov@ibykus.de

Signed-off-by: Michael Sementsov <michael.sementsov@ibykus.de>
@nprigour

nprigour commented Oct 5, 2018

Copy link
Copy Markdown
Contributor

Issue confirmed. My only concern is whether it is appropriate to add to EnableAcceptEditCommandHandlerActivator class a dependancy on org.eclipse.ui.* classes.

@akater320

Copy link
Copy Markdown
Contributor

This is still a problem.
I agree the proposed fix is not as elegant as we might like.
Perhaps we need to get at the root cause of why the acceptCommands are executed 8 - eight - times.
It looks like org.eclipse.e4.ui.bindings.keys.KeyBindingDispatcher.executeCommand(,) is not flagging the event as handled and the event gets fired by every control in the hierarchy as a "traverse" event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants