Makefile colorization: fix old issues and improvement (~4 changes)#33327
Makefile colorization: fix old issues and improvement (~4 changes)#33327fadeevab wants to merge 8 commits into
Conversation
|
@fadeevab, It will cover your contributions to all Microsoft-managed open source projects. |
|
@aeschli Pull request to textmate is updated as well (textmate/make.tmbundle#15) |
|
Thanks @fadeevab . I will update the grammar next week (we're currently in the end game week). |
|
BTW, no need to make a PR. It's also good enough if you file me an issue and ask to to run the update script |
|
@fadeevab, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
Makefile use the following rule to parse variables: * A dollar sign followed by a character other than a dollar sign, open-parenthesis or open-brace treats that single character as the variable name. $$, $@, $v, $*: highlight as a single variable. $(): highlight as interpolation and parse content inside the braces. $$(): "$$" is highlighted to show it's escaped, but parse content inside braces for convenient representation.
|
I added commits and test cases. But I didn't ported them to TextMate yet. Wait until I update TextMate. The reason is that I develop in VSCode firstly. It's unreal to develop in XML format initially. |
|
@aeschli , FYI, TextMate xml is updated, you can check here the test |
|
@aeschli You can check it now. Total list of changes at the moment:
I didn't updated the latest expected result according to the new test, thus the latest build failed. |
|
Closing the PR. We are in sync with https://github.com/fadeevab/make.tmbundle |
|
Thank you! |
Before:


After:
Total list of changes at the moment: