build: really enable unbundling of simdjson, simdutf, ada#55886
Closed
jirutka wants to merge 3 commits into
Closed
build: really enable unbundling of simdjson, simdutf, ada#55886jirutka wants to merge 3 commits into
jirutka wants to merge 3 commits into
Conversation
Collaborator
|
Review requested:
|
The --shared-ada flag was introduced in nodejs#52924, but the implementation was incomplete. Resolves nodejs#52914
The --shared-simdjson flag was introduced in nodejs#52924, but the implementation was incomplete. Resolves nodejs#52914
The --shared-simdutf flag was introduced in nodejs#52924, but the implementation was incomplete. Resolves nodejs#52914
anonrig
approved these changes
Nov 16, 2024
Collaborator
Collaborator
richardlau
approved these changes
Nov 18, 2024
Collaborator
|
Landed in a8daa45...64c647e |
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
This was referenced Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #52924 which was incomplete.