src: include node_api_types.h instead of node_api.h in node.h#60496
Closed
addaleax wants to merge 1 commit into
Closed
src: include node_api_types.h instead of node_api.h in node.h#60496addaleax wants to merge 1 commit into
node_api_types.h instead of node_api.h in node.h#60496addaleax wants to merge 1 commit into
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit: Split out #60512 from this PR and marking this PR as blocked on it
Including
node.hshould not result in all of Node-API also being available to callers. Users who wantnode_api.hcontents should explicitly include that header.We currently include it specifically for
napi_addon_register_func; by moving that intonode_api_types.hand including that instead, we can reduce unintentionally included API surface a lot.Refs: #60345 (comment)