Skip to content

8290463: Fix several comment typos in sun.security.ec#9541

Closed
HollowMan6 wants to merge 1 commit into
openjdk:masterfrom
HollowMan6:master
Closed

8290463: Fix several comment typos in sun.security.ec#9541
HollowMan6 wants to merge 1 commit into
openjdk:masterfrom
HollowMan6:master

Conversation

@HollowMan6

@HollowMan6 HollowMan6 commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

inifinity -> infinity
nonnce -> nonce
hasg -> hash

Signed-off-by: Hollow Man hollowman@opensuse.org


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290463: Fix several comment typos in sun.security.ec

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9541/head:pull/9541
$ git checkout pull/9541

Update a local copy of the PR:
$ git checkout pull/9541
$ git pull https://git.openjdk.org/jdk pull/9541/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9541

View PR using the GUI difftool:
$ git pr show -t 9541

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9541.diff

Signed-off-by: Hollow Man <hollowman@opensuse.org>
@bridgekeeper

bridgekeeper Bot commented Jul 18, 2022

Copy link
Copy Markdown

👋 Welcome back HollowMan6! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 18, 2022

Copy link
Copy Markdown

⚠️ @HollowMan6 a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 92067e200346c41c2f43763edc01c97c7da1a9e6
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk

openjdk Bot commented Jul 18, 2022

Copy link
Copy Markdown

@HollowMan6 The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk Bot added the security security-dev@openjdk.org label Jul 18, 2022
@HollowMan6 HollowMan6 changed the title Fix several comment typos in sun.security.ec 8290463: Fix several comment typos in sun.security.ec Jul 19, 2022
@openjdk openjdk Bot added the rfr Pull request is ready for review label Jul 19, 2022
@mlbridge

mlbridge Bot commented Jul 19, 2022

Copy link
Copy Markdown

Webrevs

@XueleiFan XueleiFan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@openjdk

openjdk Bot commented Jul 19, 2022

Copy link
Copy Markdown

@HollowMan6 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290463: Fix several comment typos in sun.security.ec

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@XueleiFan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Jul 19, 2022
@HollowMan6

Copy link
Copy Markdown
Contributor Author

/integrate

@openjdk openjdk Bot added the sponsor Pull request is ready to be sponsored label Jul 19, 2022
@openjdk

openjdk Bot commented Jul 19, 2022

Copy link
Copy Markdown

@HollowMan6
Your change (at version d5af7eb) is now ready to be sponsored by a Committer.

@XueleiFan

Copy link
Copy Markdown
Member

/sponsor

@openjdk

openjdk Bot commented Jul 19, 2022

Copy link
Copy Markdown

Going to push as commit af86cd3.
Since your change was applied there have been 14 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Jul 19, 2022
@openjdk openjdk Bot closed this Jul 19, 2022
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 19, 2022
@openjdk

openjdk Bot commented Jul 19, 2022

Copy link
Copy Markdown

@XueleiFan @HollowMan6 Pushed as commit af86cd3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants