Skip to content
This repository was archived by the owner on Feb 27, 2024. It is now read-only.

Revise the exclusive ordered comparison rules to no longer imply !=V.*#3

Merged
ncoghlan merged 1 commit into
pypa:masterfrom
dstufft:rework-ordered-comparison
Dec 31, 2014
Merged

Revise the exclusive ordered comparison rules to no longer imply !=V.*#3
ncoghlan merged 1 commit into
pypa:masterfrom
dstufft:rework-ordered-comparison

Conversation

@dstufft

@dstufft dstufft commented Dec 29, 2014

Copy link
Copy Markdown
Member

Instead of having these operators imply a !=V.* this will instead have them more-or-less simply check if the prospective version is greater than or less than the specifier version. They will not however match a post or pre-release of the version mentioned in the specifier unless the specifier itself contains a post or a pre-release. In addition, we will ensure that >V does not match V+local.version even though it is technically greater than V.

In particular that means that something like >1.7 will match 1.7.1 but will not match 1.7.post1 while >1.7.post0 would. Likewise <3.0 would not match 3.0.dev0 while <3.0rc1 would.

This is implemented in pypa/packaging#25

@dstufft dstufft added the PEP440 label Dec 29, 2014
Comment thread PEP-0440.rst Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing the closing ``

@ncoghlan

Copy link
Copy Markdown
Member

Some minor editorial comments, and an actual error picked up by Marcus, but overall this looks good to me.

I unfortunately renamed the PEP 440 file based on the discussion in issue #2, so that will also need changing in the PR before it will apply cleanly again.

@dstufft dstufft force-pushed the rework-ordered-comparison branch from b7cabbd to 797df18 Compare December 29, 2014 07:19
@dstufft

dstufft commented Dec 29, 2014

Copy link
Copy Markdown
Member Author

This is updated now.

Comment thread pep-0440-versioning.rst Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still another s/should/will/ here.

@ncoghlan

Copy link
Copy Markdown
Member

Generally looks good to me - just one change that was missed from the previous review, and a realisation that the change log could likely use an introductory paragraph.

@dstufft dstufft force-pushed the rework-ordered-comparison branch from 797df18 to def6195 Compare December 29, 2014 14:21
@dstufft

dstufft commented Dec 29, 2014

Copy link
Copy Markdown
Member Author

Updated again.

@ncoghlan

Copy link
Copy Markdown
Member

Merging this one - I'll also add the 'c'->'rc' normalisation change to the changelog, and then give folks on distutils-sig one last chance to comment before we publish the change on python.org

ncoghlan added a commit that referenced this pull request Dec 31, 2014
Revise the exclusive ordered comparison rules to no longer imply !=V.*
@ncoghlan ncoghlan merged commit 225de0a into pypa:master Dec 31, 2014
@dstufft dstufft deleted the rework-ordered-comparison branch December 31, 2014 02:19
@dstufft

dstufft commented Dec 31, 2014

Copy link
Copy Markdown
Member Author

At what point can I merge the packaging PR and release it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants