Add futures and backport to Python 2.7 test requirements#1572
Merged
Conversation
pganssle
added a commit
to pganssle/setuptools
that referenced
this pull request
Nov 3, 2018
`setuptools.tests.test_build_meta` relies on the Python 3 feature `concurrent.futures` to run, and as a result has been silently skipped in Python 2.7. This adds the `futures` backport to the 2.7 test requirements and turns the `pytest.importorskip` invocations in test_build_meta into standard import statements.
bfbd607 to
b2cbe86
Compare
|
Any idea if this fixes the python 2 backport of futures being installed on a python 3 environment? I'm planning on filing a bug report for it, but am still testing what is going on and what may fix it. Looks like with setuptools 40.5, it is installing |
Member
Author
|
This PR only affects the setuptools tests, so it shouldn't change anything for users of setuptools. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setuptools.tests.test_build_metarelies on the Python 3 featureconcurrent.futuresto run, and as a result has been silently skipped in Python 2.7. This adds thefuturesbackport to the 2.7 test requirements and turns thepytest.importorskipinvocations in test_build_meta into standard import statements.Pull Request Checklist