Include pyproject.toml in sdist#1634
Merged
Merged
Conversation
pganssle
reviewed
Jan 11, 2019
3 tasks
Member
|
Gah. This PR seemed like a pretty innocuous request, and since the tests had passed, I merged it. But now I see this change causes tests to fail in master when pip 19 is present (now that setuptools' own pyproject.toml is now present). This is another manifestation of #1644. |
Member
|
@jaraco Is this included in a release yet? I think this shouldn't be included in any release unless that release also handles the "default PEP 517 backend" issue. |
Member
|
It is not. |
Member
|
This merge is the last thing on master. I'm going to force-push master back to its prior state. |
Member
|
Member
|
If you'd pulled the latest master, please on master: |
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Include
pyproject.tomlin source distribution if it is present.Closes #1632
Pull Request Checklist