Fixes for python3.10#1824
Merged
Merged
Conversation
This was referenced Aug 18, 2019
Contributor
Author
|
@pganssle would appreciate a review <3 |
Member
|
I think it might be good to pull this from a centralized place rather than repeating the same formatting idiom in a bunch of places. |
Contributor
Author
|
sounds good -- do you have a recommended place to put this little helper "constant"? |
Contributor
Author
|
@pganssle ping! should I put these in some sort of |
Member
Member
|
Honestly, I struggle with a good place to put this logic, because the usage appears in
There's just no good place to this indication. Here's what I suggest - let's wait for this idiom (or the resulting value) to appear in And in the meantime, let's accept it as proposed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
found using asottile/python3.10
Pull Request Checklist