Skip to content

Fixes for python3.10#1824

Merged
jaraco merged 1 commit into
pypa:masterfrom
asottile:python310
Oct 27, 2019
Merged

Fixes for python3.10#1824
jaraco merged 1 commit into
pypa:masterfrom
asottile:python310

Conversation

@asottile

@asottile asottile commented Aug 18, 2019

Copy link
Copy Markdown
Contributor

Summary of changes

found using asottile/python3.10

Pull Request Checklist

  • Changes have tests -- 17 tests failed prior to this change
  • News fragment added in changelog.d. See documentation for details

@asottile

Copy link
Copy Markdown
Contributor Author

@pganssle would appreciate a review <3

@pganssle

Copy link
Copy Markdown
Member

I think it might be good to pull this from a centralized place rather than repeating the same formatting idiom in a bunch of places.

@asottile

Copy link
Copy Markdown
Contributor Author

sounds good -- do you have a recommended place to put this little helper "constant"?

@asottile

Copy link
Copy Markdown
Contributor Author

@pganssle ping! should I put these in some sort of _compat module?

@pganssle

pganssle commented Oct 3, 2019

Copy link
Copy Markdown
Member

@asottile I dunno if _compat is right, it's more like _environment or _platform or something.

The one in setup.py can stay as it is, though.

@jaraco Do you have any suggestions, code-organization-wise?

@jaraco

jaraco commented Oct 27, 2019

Copy link
Copy Markdown
Member

Honestly, I struggle with a good place to put this logic, because the usage appears in

  • setuptools/* (4)
  • pkg_resources/* (including doctests) (3)
  • setup.py (1)

There's just no good place to this indication. Here's what I suggest - let's wait for this idiom (or the resulting value) to appear in packaging (on which both pkg_resources and setuptools both depend) and then rely on it from there (except maybe for setup.py).

And in the meantime, let's accept it as proposed.

@jaraco jaraco merged commit e3068ee into pypa:master Oct 27, 2019
@asottile asottile deleted the python310 branch October 27, 2019 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants