fix possible issue with transitive build dependencies#1922
Merged
jaraco merged 3 commits intoDec 1, 2019
Merged
Conversation
4c9bea1 to
8b20dfd
Compare
|
It seems I'm impacted by this bug too, with one difference : my use case is dependencies in So, the proposed fix should be ok (it's in a generic code path that is used for both EDIT: I tested the patch of this PR in my context, and it does indeed fix the IndexError :) |
frivoire
reviewed
Nov 27, 2019
frivoire
reviewed
Nov 27, 2019
Handle the case where a missing transitive build dependency is required by an extra for an already installed build dependency.
8b20dfd to
7502dc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle the case where a missing transitive build dependency is required by an extra for an already installed build dependency.
Example:
setup.pycontaining:setup_requires=['dep[extra]']depis already installed, and the dependencies forextraare:['extra_dep']extra_depis not already installed, andfetch_build_egg('extra_dep; extra =="extra"')is calledIf the marker is not stripped,
pip wheel [...] 'extra_dep; extra =="extra"'ignores the requirement, and does not build a wheel, but still returns with no error.Summary of changes
Closes the second issue found in #1920.
Pull Request Checklist