Skip to content

Remove pkg_resources.py31compat.makedirs() in favor of the stdlib#1973

Merged
jaraco merged 1 commit into
pypa:masterfrom
jdufresne:makedirs
Jun 15, 2020
Merged

Remove pkg_resources.py31compat.makedirs() in favor of the stdlib#1973
jaraco merged 1 commit into
pypa:masterfrom
jdufresne:makedirs

Conversation

@jdufresne

@jdufresne jdufresne commented Jan 18, 2020

Copy link
Copy Markdown
Contributor

As setuptools is now python 3.5+, this compatibility shim is no longer
necessary.

Closes

Pull Request Checklist

  • Changes have tests
  • News fragment added in changelog.d. See documentation for details

@pganssle

Copy link
Copy Markdown
Member

@jdufresne Before you go too far in this, we are still maintaining support for Python 2, despite the change in the declared support (note the CI matrix).

We won't be ready to merge these sorts of PRs for some months to come.

@jdufresne

Copy link
Copy Markdown
Contributor Author

Depending on if pkg_resources.py31compat is considered a public interface, this could be considered a breaking change. If it should go through a deprecation cycle, please let me know. My ultimate goal is to remove six.py from the project, this is just a first step.

@jdufresne

Copy link
Copy Markdown
Contributor Author

We won't be ready to merge these sorts of PRs for some months to come.

Got it! Thanks for the heads up. I'll hold off until later then.

@pganssle

Copy link
Copy Markdown
Member

@jdufresne That said, we may want to actually go ahead with deprecation warnings on all these things if it's not too much effort.

Just move all our internal uses of the compat stuff to another pointer and make public wrappers saying to migrate away from the compatibility shims, maybe?

@jaraco

jaraco commented Jan 19, 2020

Copy link
Copy Markdown
Member

I don't expect any users to be relying on these compatibility shim modules. I would expect not to have a deprecation period for these modules.

As setuptools is now python 3.5+, this compatibility shim is no longer
necessary.
@jaraco jaraco removed the deferred label Jun 15, 2020
@jaraco jaraco merged commit 3083142 into pypa:master Jun 15, 2020
@jdufresne jdufresne deleted the makedirs branch December 18, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants