Merged
Conversation
Signed-off-by: Reece Dunham <me@rdil.rocks>
Signed-off-by: Reece Dunham <me@rdil.rocks>
jaraco
reviewed
May 3, 2020
| * #572: In build_ext, now always import ``_CONFIG_VARS`` | ||
| from ``distutils`` rather than from ``sysconfig`` | ||
| to allow ``distutils.sysconfig.customize_compiler`` | ||
| configure the OS X compiler for ``-dynamiclib``. |
Member
There was a problem hiding this comment.
Does it make sense to change the entries in the changelog? After all, at the time, it was called OS X.
jaraco
reviewed
May 3, 2020
|
|
||
|
|
||
| def _macosx_vers(_cache=[]): | ||
| def _macos_vers(_cache=[]): |
Member
There was a problem hiding this comment.
While we're at it, let's rename these to _macOS_vers. I prefer to honor the casing when possible.
jaraco
reviewed
May 3, 2020
| See <http://github.com/ActiveState/appdirs> for details and usage. | ||
| """ | ||
| # Dev Notes: | ||
| # - MSDN on where to store app data files: |
Member
There was a problem hiding this comment.
Please revert anything in _vendor. These files are maintained upstream. You'll want to contribute this change to the upstream package.
jaraco
requested changes
May 3, 2020
jaraco
left a comment
Member
There was a problem hiding this comment.
I appreciate you making this change. Just want to be less aggressive about it. After reverting the changes to CHANGES.rst and _vendor/**, it's good to go.
jaraco
added a commit
that referenced
this pull request
May 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Reece Dunham me@rdil.rocks
Summary of changes
OS X isn't what macOS is called anymore. This fixes it.
A couple other small fixes included aswell related.
Pull Request Checklist