Skip to content

Fix exception causes all over the codebase#2199

Merged
jaraco merged 2 commits into
pypa:masterfrom
cool-RR:2020-06-11-raise-from
Jul 3, 2020
Merged

Fix exception causes all over the codebase#2199
jaraco merged 2 commits into
pypa:masterfrom
cool-RR:2020-06-11-raise-from

Conversation

@cool-RR

@cool-RR cool-RR commented Jun 16, 2020

Copy link
Copy Markdown
Contributor

This is a continuation of #2189 .

@cool-RR cool-RR force-pushed the 2020-06-11-raise-from branch 2 times, most recently from 6d31fbc to d0d2f8c Compare June 16, 2020 10:42
@cool-RR cool-RR marked this pull request as ready for review June 21, 2020 10:17
@cool-RR

cool-RR commented Jun 21, 2020

Copy link
Copy Markdown
Contributor Author

@jaraco Looks like I forgot to mark this as "ready for review", I did that now.

@cool-RR

cool-RR commented Jun 28, 2020

Copy link
Copy Markdown
Contributor Author

@jaraco Nudge

Comment thread setuptools/dist.py

@jaraco jaraco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changelog entry?

@cool-RR cool-RR force-pushed the 2020-06-11-raise-from branch from d0d2f8c to a9eb9e7 Compare June 28, 2020 19:21
@cool-RR

cool-RR commented Jun 28, 2020

Copy link
Copy Markdown
Contributor Author

Fixed.

@jaraco jaraco merged commit 990237c into pypa:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants