Add mechanism for comparison of setup.py and its equivalent setup.cfg#2584
Merged
Conversation
jaraco
reviewed
Mar 5, 2021
…s the (sole) change from other concerns.
jaraco
approved these changes
Mar 5, 2021
jaraco
left a comment
Member
There was a problem hiding this comment.
This is beautiful. I honestly did not expect this change to be possible, but the solution you found and implemented is simple and elegant. Thoroughly impressed and grateful.
This was referenced Mar 8, 2021
Closed
This was referenced Mar 15, 2021
Merged
Merged
1 task
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Closes #1699
Add the sphinx-inline-tabs extension to allow tabbed containers for comparing
setup.pyandsetup.cfg. The tabs works even when JS is disabled. This PR also replaces instances of adjacent code-blocks with the new extension.However, I wasn't sure if there was an issue with the default styling. It currently looks like this:
The only thing that stood out and possibly needed overriding was the accent color of the tabs.
Pull Request Checklist
Changes have testschangelog.d/.(See documentation for details)