Merge with distutils@85db7a41242#2902
Closed
jaraco wants to merge 11 commits into
Closed
Conversation
Adds a unit test for that scenario
`setuptools.build_meta` uses `tokenize.open` instead of open (and replaces `\r\n` with `\n`) when exec-ing `setup.py` files. It seems that the advantage of using `tokenize.open` is that it supports automatic encoding detection.
This allows reusing the function for already made distribution objects.
Update `distutils.core.setup/run_setup` to better match `setuptools.build_meta`.
786274c to
4bde5da
Compare
Member
Author
|
Merged manually to avoid double merge commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if __name__ == '__main__'Summary of changes
Closes
Pull Request Checklist
changelog.d/.(See documentation for details)