Merged
Conversation
Member
|
Inferring from the bug report, the issue is that the DistutilsMetaFinder is creating a spec without a valid origin, creating a spec that is inferred to be a namespace package. I might re-arrange the test a bit, but this is great. Thanks for the contrib. |
set origin so spec finding reports the correct location -- https://docs.python.org/3/library/importlib.html#importlib.machinery.ModuleSpec
Member
|
I confirmed that 91ce77e captures the failed expectation when run with SETUPTOOLS_USE_DISTUTILS=local, which is run in CI, so I believe it to be a more selective and less entangled test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set origin so spec finding reports the correct location -- https://docs.python.org/3/library/importlib.html#importlib.machinery.ModuleSpec
Summary of changes
Closes asottile/reorder-python-imports#210
Pull Request Checklist
changelog.d/.(See documentation for details)