Make sure auto-discovery does not break include_package_data

[abravalheri]

This is an attempt to fix #3196

Summary of changes

• Avoid auto-discovery to add entries to package_dir in flat-layouts
• Avoid using paths starting with ./ in package_dir

Closes

Pull Request Checklist

• Changes have tests
• News fragment added in changelog.d/.
  (See documentation for details)

[blink1073]

I confirmed this fixes jupyter_releaser, but I can't test this with jupyter_server due to a dependency conflict:

 The user requested setuptools 61.0.0.post20220325.post-20220325 (from git+https://github.com/abravalheri/setuptools.git@issue-3196)
    jupyter-packaging 0.9.0 depends on setuptools>=49.4.0

[blink1073]

LGTM, thanks!

[abravalheri]

I can't test this with jupyter_server due to a dependency conflict:

Yes I experienced the same trouble here locally when trying to test jupyter_server. Then after a workaround, I found some other problems related to npm... Then I finally gave up 😅

Hopefully it will work.

Thank you very much Steven for checking the PR!

[blink1073]

I found some other problems related to npm... Then I finally gave up 😅

Haha good call, the bane of Jupyter-development.

[abravalheri]

Haha good call, the bane of Jupyter-development.

Sorry 😝, I promise I will get back to it soon.

[blink1073]

No worries, I'll double-check once a patch release is out.

[blink1073]

We already merged jupyter-server/jupyter_server#757 as a workaround anyway, but I'll make sure it works without that patch.

[abravalheri]

Thank you very much for the help and the understanding.

[kosteev]

We have our CI pipelines broken because of this and while we are working on the fix on our side we are curious if there is an ETA for releasing this fix?

[abravalheri]

Hi @kosteev, being optimistic, if Github actions/hooks don't go bad again I hope to get the first batch of fixes out still today (I am at UTC).

[kosteev]

Thank you!

[MetRonnie]

I had the same problem as the original issue (only affected Python 3.7 on GH Actions, couldn't reproduce locally). Anyway, I have tested this fix out by pip installing setuptools from the GH repo instead of PyPI and can confirm the problem is fixed 👍 (for me at least)

[blink1073]

v61.1.0 fixes the issue in jupyter_server. Thanks again for the hard work and quick fixes @abravalheri, have a great weekend!