Add warning for potential extras_require misconfiguration#3481
Conversation
40e07e8 to
195e4e1
Compare
|
Some of the jobs in CI are already green so this shouldn't break setuptools. I'm gonna add one more test. |
195e4e1 to
bdd8e1b
Compare
abravalheri
left a comment
There was a problem hiding this comment.
Thank you very much @frenzymadness for the work in this improvement. I added a few review comments/suggestions (but please feel free to disagree or propose alternatives).
|
I believe I addressed all the comments. |
|
I have one fixup commit there. Don't forget to squash it to the previous one before merging. Thanks for helping me with this! |
…tal_env_marker_misconfig
7dcef6c to
22a1099
Compare
|
I was writing the following message before I noticed that I did a mistake in the refactoring and went back to correct it:
But I guess you already noticed that 🤣
Ok, I will do it, thank you for the pointer. |
|
Thank you very much @frenzymadness, I plan to merge this PR together with a few other ones in a new release soon. |
Fixes: #3467
Summary of changes
See the linked issue, all details are there.
Closes #3467
Pull Request Checklist
changelog.d/.(See documentation for details)