Skip to content

Fix other problems with editable installs#3517

Merged
abravalheri merged 5 commits into
pypa:mainfrom
abravalheri:issue-3513
Aug 12, 2022
Merged

Fix other problems with editable installs#3517
abravalheri merged 5 commits into
pypa:mainfrom
abravalheri:issue-3513

Conversation

@abravalheri

Copy link
Copy Markdown
Contributor

Motivated by pyca/cryptography use case.

Summary of changes

  1. Ensure commands are finalized, to ensure plat_name is set.
  2. Filter out temporary source files and prevent setuptools for attempting to consider them as part of the data_files/package_data list

Closes #3513

Pull Request Checklist

  • Changes have tests -- partially. I did not manage to find a small reproducer for change 2.
  • News fragment added in changelog.d/.
    (See documentation for details)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] plat_name attribute is None with setuptools 64.0.1 and editable install

1 participant