Remove msvc hack for Numpy < 1.11.2

[mgorny]

Summary of changes

Remove the msvc hack that was applied if numpy.distutils were loaded prior to Numpy 1.11.2. These versions date back to June 2016 and no longer build with Python 3.7. At the same time, the hack relies on packaging.version.LegacyVersion that is removed in packaging 22.0.

Pull Request Checklist

• Changes have tests
• News fragment added in changelog.d/.
  (See documentation for details)

[mgorny]

Hmm, is CI broken?

[abravalheri]

Let's try now with a rebase.

[abravalheri]

@Mergifyio rebase

[jaraco]

Looking at the error message, I think this change introduces a fault. monkey.patch_all is no longer able to patch distutils with the removed function. Probably if the hack is no longer needed, it should also be removed from the monkeypatching of distutils.

[mgorny]

Looking at the error message, I think this change introduces a fault. monkey.patch_all is no longer able to patch distutils with the removed function. Probably if the hack is no longer needed, it should also be removed from the monkeypatching of distutils.

Thanks. My grep-foo has been poor there.

[mgorny]

Ok, I think it's good now.

[mgorny]

Thanks!