Align towncrier with defaults#3960
Merged
Merged
Conversation
256a399 to
8f00783
Compare
8f00783 to
5f09e71
Compare
5f09e71 to
eec808a
Compare
eec808a to
578480e
Compare
Member
Author
|
Tests are failing on cygwin because the new jaraco.develop dependency has some logic for uploading secrets to Github, which requires PyNaCl, which is built on CFFI, which cygwin doesn't support. We'll have to find a way to exclude that dependency. |
fccc3e3 to
be206da
Compare
Member
Author
|
I'm going to push forward with merging this to unblock refreshing the skeleton. I welcome feedback, but for the most part, I expect this change to have minimal impact with one exception - existing PR changelogs will need to be updated:
I'll help out with that this weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As jaraco/skeleton is adopting towncrier, that upstream project is attempting to honor the default settings wherever possible.
These changes attempt to align with those defaults and re-use the functionality added upstream for managing towncrier.
Summary of changes