Skip to content

pkg_resources: Remove unused and shadowed variables#4260

Merged
abravalheri merged 1 commit into
pypa:mainfrom
Avasam:pkg_resources-remove-unused-and-shadowed
Mar 6, 2024
Merged

pkg_resources: Remove unused and shadowed variables#4260
abravalheri merged 1 commit into
pypa:mainfrom
Avasam:pkg_resources-remove-unused-and-shadowed

Conversation

@Avasam

@Avasam Avasam commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

Summary of changes

Extracted from https://github.com/pypa/setuptools/pull/4242/files#r1513644506

Pull Request Checklist

  • Changes have tests (existing tests should pass, this should all be dead code)
  • News fragment added in newsfragments/.
    (See documentation for details)

@Avasam Avasam force-pushed the pkg_resources-remove-unused-and-shadowed branch from 745f3c7 to ba09176 Compare March 6, 2024 17:35
@abravalheri

abravalheri commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

Thanks @Avasam, I think we can merge this one as soon as the CI passes.


For future readers wondering if the PR would change the exposed API, we have discussed this in #4242 (comment), and the conclusion is that this PR should be safe ( _initialize_master_working_set is already doing all the work).

@abravalheri abravalheri merged commit 9b081af into pypa:main Mar 6, 2024
@Avasam Avasam deleted the pkg_resources-remove-unused-and-shadowed branch March 6, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants