Skip to content

Avoid leaking "name" variable in AbstractSandbox#4280

Merged
abravalheri merged 1 commit into
pypa:mainfrom
Avasam:leaked-name-variable-in-AbstractSandbox
Apr 16, 2024
Merged

Avoid leaking "name" variable in AbstractSandbox#4280
abravalheri merged 1 commit into
pypa:mainfrom
Avasam:leaked-name-variable-in-AbstractSandbox

Conversation

@Avasam

@Avasam Avasam commented Mar 15, 2024

Copy link
Copy Markdown
Contributor

Summary of changes

This was noticed in typeshed:
https://github.com/python/typeshed/blob/449f70f1f1bc787eb56699a5ce153c3efbfe2f4f/stubs/setuptools/%40tests/stubtest_allowlist.txt#L40-L41

Before:

>>> from setuptools.sandbox import AbstractSandbox
>>> AbstractSandbox.name
'tmpnam'

After:

>>> from setuptools.sandbox import AbstractSandbox
>>> AbstractSandbox.name
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: type object 'AbstractSandbox' has no attribute 'name'

Pull Request Checklist

@Avasam Avasam force-pushed the leaked-name-variable-in-AbstractSandbox branch from d71d637 to 2b339b9 Compare March 15, 2024 04:53
@abravalheri abravalheri merged commit 683ad33 into pypa:main Apr 16, 2024
@abravalheri

Copy link
Copy Markdown
Contributor

Thank you very much!

@Avasam Avasam deleted the leaked-name-variable-in-AbstractSandbox branch April 16, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants