Skip to content

Fix "Wheel naming is not following PEP 491 convention"#4766

Merged
jaraco merged 14 commits into
pypa:mainfrom
di:fix/3777
Feb 2, 2025
Merged

Fix "Wheel naming is not following PEP 491 convention"#4766
jaraco merged 14 commits into
pypa:mainfrom
di:fix/3777

Conversation

@di

@di di commented Dec 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Summary of changes

Fixes #3777.

Marking this as draft as there is one outstanding failing test that I have been unable to resolve (setuptools/tests/test_easy_install.py::TestSetupRequires::test_setup_requires_override_nspkg).

Pull Request Checklist

@di di mentioned this pull request Dec 10, 2024
Closed
@abravalheri

abravalheri commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

Thank you!

The failing test seems to be happening now regardless of this change: https://github.com/pypa/setuptools/actions/runs/12298183072/job/34321035714#step:3:49.

I don't know if anything changed in the latest versions of Python being distributed to macOS, so that __file__ is no longer available on the scope.

@di

di commented Dec 12, 2024

Copy link
Copy Markdown
Member Author

Aha, that's a different failure actually, setuptools/tests/test_easy_install.py::TestSetupRequires::test_setup_requires_override_nspkg is the test that is legitimately failing and would need to be updated here.

@abravalheri

abravalheri commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

setuptools/tests/test_easy_install.py::TestSetupRequires::test_setup_requires_override_nspkg is the test that is legitimately failing and would need to be updated here.

This looks like it is checking deprecated functionality? Not sure we have to account such an edge case since we are moving away from easy_install. Maybe we can do a major bump to show that the change may be considered a breaking change.

@di

di commented Dec 12, 2024

Copy link
Copy Markdown
Member Author

I'm not sure! I think the test is just broken in a way I haven't been able to figure out (it mixes the distribution name and the namespace name as one thing in the helper functions) but I think the underlying functionality probably still works?

@di

di commented Jan 9, 2025

Copy link
Copy Markdown
Member Author

All tests are passing, this is now ready for review.

@di di marked this pull request as ready for review January 9, 2025 22:55
@henryiii henryiii mentioned this pull request Jan 15, 2025
Closed
jaraco
jaraco approved these changes Jan 26, 2025
View reviewed changes

@jaraco jaraco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't make me happy to approve this change, but I've conceded the fight. Let's align with the spec.

Comment thread setuptools/command/bdist_wheel.py Outdated
Comment thread setuptools/tests/test_easy_install.py Outdated
Comment thread setuptools/tests/test_easy_install.py Outdated
@di di requested a review from jaraco January 27, 2025 16:38
@di

di commented Jan 29, 2025

Copy link
Copy Markdown
Member Author

This is ready for re-review.

@konstin konstin mentioned this pull request Jan 30, 2025
Closed
@jaraco jaraco merged commit 75f7782 into pypa:main Feb 2, 2025
@di di deleted the fix/3777 branch February 2, 2025 23:18
@teojgo teojgo mentioned this pull request Feb 25, 2025
Merged
@notatallshaw notatallshaw mentioned this pull request Feb 25, 2025
Open
@krpatter-intc krpatter-intc mentioned this pull request Feb 25, 2025
Closed
@di di mentioned this pull request Feb 26, 2025
Merged
@mauritsvanrees mauritsvanrees mentioned this pull request Feb 26, 2025
Merged
@Alex-Preciado Alex-Preciado mentioned this pull request Feb 28, 2025
Merged
@PietropaoloFrisoni PietropaoloFrisoni mentioned this pull request Mar 5, 2025
Merged
@JCGoran JCGoran mentioned this pull request Mar 5, 2025
Closed
This was referenced Mar 5, 2025
Merged
Merged
Merged
@linzhp linzhp mentioned this pull request Mar 6, 2025
Closed
@Avasam Avasam mentioned this pull request Mar 10, 2025
Closed
@di di mentioned this pull request Mar 11, 2025
Closed
jaraco added a commit that referenced this pull request Mar 11, 2025
@jaraco
Merge pull request #4766 from di/fix/3777
9559193 
Fix "Wheel naming is not following PEP 491 convention"
@jaraco jaraco mentioned this pull request Mar 11, 2025
Merged
2 tasks
denik added a commit to databricks/cli that referenced this pull request Mar 20, 2025
@denik
acc: lower case UNIQUE_NAME
f1f5071 
Same reason as for #2380
This makes $UNIQUE_NAME usable in PyPI distribution names, which are lowercased: pypa/setuptools#4766
@denik denik mentioned this pull request Mar 20, 2025
Merged
github-merge-queue Bot pushed a commit to databricks/cli that referenced this pull request Mar 20, 2025
@denik
acc: lower case UNIQUE_NAME (#2534)
9fd1b9c 
Same reason as for #2380

This makes $UNIQUE_NAME usable in PyPI distribution names, which are
lowercased: pypa/setuptools#4766
@speth speth mentioned this pull request Mar 21, 2025
Merged
5 tasks
@marcelotduarte marcelotduarte mentioned this pull request Apr 2, 2025
Merged
@elprans elprans mentioned this pull request Apr 11, 2025
Merged
elprans added a commit to geldata/metapkg that referenced this pull request Apr 11, 2025
@elprans
Fix breakage caused by setuptools recent PEP 491 fix
339b754 
In pypa/setuptools#4766 the `.dist-info`
directory name was normalized to conform to PEP 491, which broke
content introspection for Python packages.  Adapt some of the
normalization from setuptools to match.
@elprans elprans mentioned this pull request Apr 11, 2025
Merged
elprans added a commit to geldata/metapkg that referenced this pull request Apr 11, 2025
@elprans
Fix breakage caused by setuptools recent PEP 491 fix (#44)
ef0c448 
In pypa/setuptools#4766 the `.dist-info`
directory name was normalized to conform to PEP 491, which broke
content introspection for Python packages.  Adapt some of the
normalization from setuptools to match.
@dotlambda dotlambda mentioned this pull request May 15, 2025
Merged
13 tasks
archlinux-github pushed a commit to archlinux/aur that referenced this pull request May 18, 2025
@0x9fff00
fix build with setuptools >=75.8.1
e0fa499 
pypa/setuptools#4766
pypa/setuptools#4728
@danyeaw danyeaw mentioned this pull request Dec 4, 2025
Open
2 tasks
@RogerMarsh RogerMarsh mentioned this pull request Jan 22, 2026
Closed
denik added a commit to databricks/cli that referenced this pull request May 20, 2026
@denik
acc: lower case UNIQUE_NAME (#2534)
dedc889 
Same reason as for #2380

This makes $UNIQUE_NAME usable in PyPI distribution names, which are
lowercased: pypa/setuptools#4766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco jaraco approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Wheel naming is not following PEP 491 convention

4 participants

@di @abravalheri @jaraco @vvbv