Conversation
Member
|
This seems like a reasonable change. Consistency is good. The changes to files in _vendor while acceptable are discouraged as they will be overridden when that package is refreshed and also, it makes the file checksums not match any version in the upstream package. The best thing to do for those would be to request these changes in the relevant upstream package and then they'll eventually get refreshed here. |
| from setuptools.extern import six | ||
|
|
||
| # HFS Plus uses decomposed UTF-8 | ||
|
|
Member
There was a problem hiding this comment.
I think this change is wrong. In my experience, the comments should be adjacent to their relevant code. These additional new lines make the comment appear as a standalone construct.
Author
|
@jaraco Done. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.