Skip to content

gh-111513#111613

Closed
anuragdaksh7 wants to merge 3 commits into
python:mainfrom
anuragdaksh7:main
Closed

gh-111513#111613
anuragdaksh7 wants to merge 3 commits into
python:mainfrom
anuragdaksh7:main

Conversation

@anuragdaksh7

@anuragdaksh7 anuragdaksh7 commented Nov 1, 2023

Copy link
Copy Markdown

solved #111513
solved issue with datetime.datetime.fromtimestamp and datetime.datetime.utcfromtimestamp with string arguments

solved #111513
solved issue with datetime.datetime.fromtimestamp and datetime.datetime.utcfromtimestamp with string arguments
@ghost

ghost commented Nov 1, 2023

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app

bedevere-app Bot commented Nov 1, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@pganssle pganssle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not quite what the original issue was getting at. The problem is got that these methods should accept strings, but that the error message you get when you pass the wrong type to their argument implies that they only accept integers.

The way to solve the original issue is to fix the error message.

@bedevere-app

bedevere-app Bot commented Nov 1, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@bedevere-app

bedevere-app Bot commented Nov 7, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@anuragdaksh7 anuragdaksh7 closed this by deleting the head repository Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants