gh-128066: Fixed PyREPL history saving on read-only file systems

[vladimir-poghosyan]

As suggested in the comment of the linked issue by @ZeroIntensity, I simply handled the exception with a resulting warning.

• Issue: PyREPL raises exception while trying to write to the history file on a read-only file system #128066

[ghost]

All commit authors signed the Contributor License Agreement.

[skirpichev]

LGTM in general, with few concerns.

1. Maybe it worth a test.
2. I worry, that error is too late. Though, this will be fixed by #132294.

[vladimir-poghosyan]

Thank you for reviewing the PR.

I looked through your mentioned pull request an noticed that the call to append_history_file is wrapped in except (FileNotFoundError, PermissionError) exception handler, thus still prone to the same read-only file system error, or am I missing something?

Will it be better, that I add OSError to the except (FileNotFoundError, PermissionError) in the site.py (where the write_history_file is called) with a warning message and leave its implementation as it was? In that way file handling code in both write_history_file and append_history_file methods will match.

[skirpichev]

I looked through your mentioned pull request an noticed that the call to append_history_file is wrapped in except (FileNotFoundError, PermissionError) exception handler

Now I also catch OSError like in your pr.

Will it be better, that I add OSError to the except (FileNotFoundError, PermissionError) in the site.py

Hmm, maybe. (BTW I doubt that FileNotFoundError is relevant at all.)

[vladimir-poghosyan]

I've changed my implementation and moved error handling to the site.py. Regarding the the FileNotFoundError being caught, I think that it is relevant for missing directories in the history file path.

[ambv]

Closing in favor of #134380.