Skip to content

gh-133319: Use python versioning in msgfmt & pygettext#134205

Closed
StanFromIreland wants to merge 3 commits into
python:mainfrom
StanFromIreland:pyver-get-msg
Closed

gh-133319: Use python versioning in msgfmt & pygettext#134205
StanFromIreland wants to merge 3 commits into
python:mainfrom
StanFromIreland:pyver-get-msg

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented May 19, 2025

Copy link
Copy Markdown
Member

Simplest approach maintaining full backwards compatibility. We cannot use the version of the python running the script, updating this number every few years is not overly complex, it can be picked up by any pr modifying the file.

@StanFromIreland

Copy link
Copy Markdown
Member Author

Request: @tomasr8 , @serhiy-storchaka

@encukou

encukou commented May 28, 2025

Copy link
Copy Markdown
Member

This would put the burden of updating the numbers on the release manager, who bumps the CPython version. I doubt they'll want that.

Can you find a way to do this with less maintenance overhead?

@StanFromIreland

StanFromIreland commented May 28, 2025

Copy link
Copy Markdown
Member Author

IMO it shouldn’t fall on the release manager, since the file won’t have changed anyway. In my mind I think it should just be done as part of whatever pr that modifies the script in a given version.

Using the version of the python running it will be misleading.

@encukou

encukou commented May 28, 2025

Copy link
Copy Markdown
Member

Ah. Could you document that expectation; perhaps put the command to do it in a comment?

@StanFromIreland

Copy link
Copy Markdown
Member Author

perhaps put the command to do it in a comment?

I can do that.

@encukou

encukou commented May 29, 2025

Copy link
Copy Markdown
Member

Sorry, I assumed the discussion is further along.
First let's clarify what the versioning scheme should be; see discussion on the issue. After that, it'll be time to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants