bpo-44733: max_tasks_per_child + fork not allowed#32187
Closed
loganasherjones wants to merge 1 commit into
Closed
Conversation
7da44f7 to
a318683
Compare
a318683 to
bf52bfa
Compare
Contributor
Author
|
ping @gpshead don't really know who else to ping about this. |
MaxwellDupre
suggested changes
Apr 24, 2022
MaxwellDupre
left a comment
Contributor
There was a problem hiding this comment.
Can you add a test please?
Member
|
Related, I've got #91587 to do this. I'll reconcile these two and get one merged within the next couple weeks. |
Member
|
Taken care of in fa4f0a1 via my other PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes ensure that if a user specifies
max_tasks_per_childbut nomp_context, a usablemp_contextis generated automatically for them. If the user specified theforkcontext, then an error will be thrown.For more information please see:
https://bugs.python.org/issue44733